[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-bugs-dist
Subject:    [amarok] [Bug 320129] JJ: Tracks cannot be dragged around when playlist was shuffled
From:       Matěj Laitl <matej () laitl ! cz>
Date:       2013-05-31 12:23:59
Message-ID: bug-320129-71684-aiP2ZKk9lT () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=320129

Matěj Laitl <matej@laitl.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
   Version Fixed In|                            |2.8
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/amar
                   |                            |ok/5659f0f8ad73a2894ebe8d5d
                   |                            |a3f7925e75ce6901

--- Comment #4 from Matěj Laitl <matej@laitl.cz> ---
Git commit 5659f0f8ad73a2894ebe8d5da3f7925e75ce6901 by Matěj Laitl, on behalf
of Konrad Zemek.
Committed on 31/05/2013 at 14:21.
Pushed by laitl into branch 'master'.

Playlist sort widget: reimplement Shuffle "sort" as an action.

Remove now-unnecessary Shuffle handlers in sort-related functions.
Additionally, PlaylistController::moveRows() has been modified to help
with big move actions (validation complexity reduced).

Playlist::BreadcrumbItemMenu introduced to deduplicate logic between
Playlist::BreadcrumbItem and Playlist::BreadcrumbAddMenuButton.

GUI: In the playlist sort widget, the Shuffle menu entry is now
separated from other entries. Activating the entry no longer results in
a "Shuffle" sort level being added.
FIXED-IN: 2.8
REVIEW: 110658
CCMAIL: amarok-promo@kde.org

M  +1    -0    ChangeLog
M  +21   -0    src/playlist/PlaylistActions.cpp
M  +5    -0    src/playlist/PlaylistActions.h
M  +60   -64   src/playlist/PlaylistBreadcrumbItem.cpp
M  +56   -26   src/playlist/PlaylistBreadcrumbItem.h
M  +32   -47   src/playlist/PlaylistBreadcrumbItemSortButton.cpp
M  +1    -2    src/playlist/PlaylistBreadcrumbItemSortButton.h
M  +2    -27   src/playlist/PlaylistBreadcrumbLevel.cpp
M  +0    -1    src/playlist/PlaylistBreadcrumbLevel.h
M  +9    -7    src/playlist/PlaylistController.cpp
M  +12   -2    src/playlist/PlaylistController.h
M  +0    -4    src/playlist/PlaylistDefines.h
M  +8    -4    src/playlist/PlaylistModel.cpp
M  +20   -15   src/playlist/PlaylistSortWidget.cpp
M  +6    -1    src/playlist/PlaylistSortWidget.h
M  +4    -69   src/playlist/proxymodels/SortAlgorithms.cpp
M  +0    -22   src/playlist/proxymodels/SortAlgorithms.h
M  +0    -2    src/playlist/proxymodels/SortScheme.cpp
M  +24   -24   tests/playlist/TestPlaylistModels.cpp
M  +3    -1    tests/playlist/TestPlaylistModels.h

http://commits.kde.org/amarok/5659f0f8ad73a2894ebe8d5da3f7925e75ce6901

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Amarok-bugs-dist mailing list
Amarok-bugs-dist@kde.org
https://mail.kde.org/mailman/listinfo/amarok-bugs-dist

[prev in list] [next in list] [prev in thread] [next in thread]