[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-bugs-dist
Subject:    [Bug 308703] Adding Folders in the Saved Playlists doesn't trigger any write action
From:       Matěj Laitl <matej () laitl ! cz>
Date:       2012-12-31 16:17:14
Message-ID: bug-308703-71684-FbhNLEIbVR () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=308703

--- Comment #9 from Matěj Laitl <matej@laitl.cz> ---
Git commit 607ce0c3c3b89df3c16e19273e796092e26d156b by Matěj Laitl.
Committed on 31/12/2012 at 16:14.
Pushed by laitl into branch 'master'.

PrettyTreeView: proper polymorphism, revert e1cad5e80f8f40b0

Also revert "The correct edit() was not called, lacked polymorphism."

This reverts commit e1cad5e80f8f40b08c0c46d85afe0450db2c497c.

Bart, this is the right way to do it. Also, the polymorphism was not
the cause of failing edit, see the next commit.
CCMAIL: Bart Cerneels <bart.cerneels@kde.org>

M  +1    -2    src/browsers/playlistbrowser/PlaylistBrowserCategory.h
M  +6    -8    src/widgets/PrettyTreeView.cpp
M  +28   -24   src/widgets/PrettyTreeView.h

http://commits.kde.org/amarok/607ce0c3c3b89df3c16e19273e796092e26d156b

--- Comment #10 from Matěj Laitl <matej@laitl.cz> ---
Git commit 369508c70b7d9ced37afc0ddfdb661d72d17c3ab by Matěj Laitl.
Committed on 31/12/2012 at 16:25.
Pushed by laitl into branch 'master'.

QtGroupingProxy: implement buddy() to work-around design issues

This is effectively a work-around for a big design flaw in
QtGroupingProxy (which is that it "invents" its own items not present
in the original model). Technical description in the code comments.

^^^^ Bart, because of the above reason I'd prefer not to use
QtGroupingProxy in Amarok at all in long-term. Instead, we should do it
the other way around: original model would be hierarchical and the
proxy would flatten it into a table.

This fixes some bugs in the Saved Playlists and perhaps more:

BUGFIXES:
 * Fix editability and drop-ability of playlist folders.
CCMAIL: Bart Cerneels <bart.cerneels@kde.org>

M  +1    -0    ChangeLog
M  +0    -1    src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp
M  +23   -0    src/browsers/playlistbrowser/QtGroupingProxy.cpp
M  +1    -0    src/browsers/playlistbrowser/QtGroupingProxy.h

http://commits.kde.org/amarok/369508c70b7d9ced37afc0ddfdb661d72d17c3ab

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Amarok-bugs-dist mailing list
Amarok-bugs-dist@kde.org
https://mail.kde.org/mailman/listinfo/amarok-bugs-dist

[prev in list] [next in list] [prev in thread] [next in thread]