[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-bugs-dist
Subject:    [Bug 130185] Wrong (halfed) play times for mono/single channel mp3
From:       Tobias Rafreider <tobias () rafreider ! de>
Date:       2007-02-04 21:45:46
Message-ID: 20070204214546.23750.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=130185         




------- Additional Comments From tobias rafreider de  2007-02-04 22:45 -------
During the last weeks I put many efforts into hacking taglib.
I am happy to announce a taglib-1.4 hack release for that issue.

All MP3 VBR files should now have a correct song length, thus making it possible to \
use Amarok as an Ipod synchronizing tool.

Currently Amarok complies with taglib 1.4. My hack is binary compatible to version \
1.4. Amarok does not need to be recompiled.

What has been done?
- The class MPEG::Header was not correctly implemented. Invalid frames were treated \
as correct although they were not valid. This is fixed now

-  The methods for detecting frameheaders in class MPEG::File have 
been fixed. Especially the "nextFrameOffset" method has never been working well. 

- MPEG::Properties::read() can now handle Mp3 VBR files better. 
  
Comment 18 refers to the XING Header. Not all VBR files have a XING Header. I use \
streamripper to record webradio. Most of these files are VBR without such a header \
because you do not know the song length in advance.

Performance is one thing but functionality another. If you are not able to \
synchronize VBR files with an Ipod (e.g. Amarok) users get disappointed.  I \
implemented a trade-off in my hack to maintain performance. Files without XING \
Headers can be CBR or VBR. The avg. BitRate of 100 frames in the middle of a song are \
used to detect the song length now. Tests on my machine have shown that Amarok has \
still acceptable performance!

I really do not understand why core developers have ignored this issue. Comment 18 is \
a bad excuse. All other taglib independent players like XMMS, XINE, RealPlayer can \
handle this. Again Performance is one thing but functionality another!!!

You can find my hack on http://www.rafreider.de/taglib-1.4-vbr-hack.tar.gz

I hope that my hack can flow in trunk.
_______________________________________________
Amarok-bugs-dist mailing list
Amarok-bugs-dist@kde.org
https://mail.kde.org/mailman/listinfo/amarok-bugs-dist


[prev in list] [next in list] [prev in thread] [next in thread]