[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-bugs-dist
Subject:    [Bug 130185] Wrong (halfed) play times for mono/single channel mp3
From:       David Dent <thewinch () gmail ! com>
Date:       2006-12-26 19:52:08
Message-ID: 20061226195208.21140.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=130185         




------- Additional Comments From thewinch gmail com  2006-12-26 20:52 -------
In addition to the bug in #20.

taglib/mpeg/mpegheader.cpp

in method

void MPEG::Header::parse()

  // The channel mode is encoded as a 2 bit value at the end of the 3nd byte,
  // i.e. xxxxxx11

  d->channelMode = ChannelMode(uchar(data[2]) & 0x3);

It appears this is not correctly setting the channel mode to mono with mono files.

This causes a problem because the xing header offset differers for mono files.
taglib/mpeg/mpegproperties.cpp
in method
void int xingHeaderOffset MPEG::XingHeader::xingHeaderOffset(firstHeader.version(), \
firstHeader.channelMode());

xingHeaderOffset is set incorrectly for at least mpegv1 single channel files. It is \
set to 0x24 instead of 0x15. As the xingHeaderOffset is incorrect the xing header is \
not loaded and the file is assumed to be cbr and the track length is calculated \
incorrectly. _______________________________________________
Amarok-bugs-dist mailing list
Amarok-bugs-dist@kde.org
https://mail.kde.org/mailman/listinfo/amarok-bugs-dist


[prev in list] [next in list] [prev in thread] [next in thread]