[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-bugs-dist
Subject:    [Bug 136552] Amarok crashes when connecting to an MTP device
From:       Andy Kelk <andy () mopoke ! co ! uk>
Date:       2006-10-31 9:40:02
Message-ID: 20061031094002.16551.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=136552         
andy mopoke co uk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From andy mopoke co uk  2006-10-31 10:39 -------
SVN commit 600636 by kelk:

Fix crash if an MTP media device returns a playlist with an invalid track ID.
BUG: 136552



 M  +2 -0      ChangeLog  
 M  +2 -0      src/mediadevice/mtp/mtpmediadevice.cpp  


--- trunk/extragear/multimedia/amarok/ChangeLog #600635:600636
 @ -13,6 +13,8  @
     * Amarok now saves playlists with relative paths by default.
 
   BUGFIXES:
+    * Fix crash when an MTP media device returned a playlist with an 
+      invalid track ID. (BR 136552)
     * The Install MP3 support script would be run regardless of what the
       user answered to the shown dialog. (BR 136294)
     * OSD wouldn't always show up-to-date ratings. Patch by Tuomas Nurmi
--- trunk/extragear/multimedia/amarok/src/mediadevice/mtp/mtpmediadevice.cpp #600635:600636
 @ -1327,6 +1327,8  @
             for( i = 0; i < playlists->no_tracks; i++ )
             {
                 MtpTrack *track = m_idToTrack[ playlists->tracks[i] ];
+                if( track == 0 ) // skip invalid playlist entries
+                    continue;
                 MtpMediaItem *item = new MtpMediaItem( playlist );
                 item->setText( 0, track->bundle()->artist() + " - " + track->bundle()->title() );
                 item->setType( MediaItem::PLAYLISTITEM );
_______________________________________________
Amarok-bugs-dist mailing list
Amarok-bugs-dist@kde.org
https://mail.kde.org/mailman/listinfo/amarok-bugs-dist
[prev in list] [next in list] [prev in thread] [next in thread]