[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok
Subject:    Re: Patch for Bug #177403: "Amarok does not remove leading blanks
From:       Nicholas Sinlock <isolatedincident () gmail ! com>
Date:       2009-01-11 16:36:01
Message-ID: 496A1FF1.7030607 () gmail ! com
[Download RAW message or body]

Nicholas Sinlock wrote:
> Mark Kretschmann wrote:
>> On Sun, Jan 11, 2009 at 5:12 PM, Nicholas Sinlock
>> <isolatedincident@gmail.com> wrote:
>>  
>>>  In addition to stripping the leading blanks from podcast titles, I 
>>> also
>>> implemented a function to remove any part of the channel title
>>> that is also found at the start of the episode title, as in the case of
>>> Scientific American's 60 Second Science podcast, found
>>> at http://www.sciam.com/podcast/sciam_podcast_r_d.xml.   I 
>>> implemented that
>>> rather than using the decapitateString as the latter function
>>> had the side effect of sometimes removing several characters from a 
>>> word,
>>> effectively truncating a proper word into a non-proper word.
>>>
>>> The .diff is attached.
>>>     
>>
>> Thank you very much for the patch, Nicholas, but could you please
>> adhere to our coding style? It's explained in detail here:
>>
>> http://kollide.net:8060/browse/~raw,r=20999/Amarok/HACKING/intro_and_style.txt 
>>
>>
>>
>> The problem is that we have to reformat your patch before committing,
>> and this is a lot of work if done manually. We do have an
>> auto-formatter tool, but it's hard to run this over the patch alone,
>> without changing the whole file.
>>
>>   
> I apologize, I will do that from now on.  I'm still a bit new to the 
> KDE project.
>
I do not have an svn account.  Will you be committing the patch, or do I 
need to reformat the patch first?
Thanks for your help.
_______________________________________________
Amarok mailing list
Amarok@kde.org
https://mail.kde.org/mailman/listinfo/amarok
[prev in list] [next in list] [prev in thread] [next in thread]