[prev in list] [next in list] [prev in thread] [next in thread] 

List:       alsa-devel
Subject:    [alsa-devel] interleave assumption in pcm_lib ?
From:       Paul Barton-Davis <pbd () Op ! Net>
Date:       1999-12-30 16:53:14
[Download RAW message or body]

from pcm_lib_playback_write() and elsewhere:

	} else if (runtime->mode == SND_PCM_MODE_STREAM) {
		unsigned int ptr, tmpu;
		int tmp, size, size1;
		
		if ((tmp = snd_pcm_lib_interleave_len(subchn)) > 0) {
			count /= tmp;
			if (count == 0)
				return -EINVAL;
			count *= tmp;
		}

this code assumes interleaving, since snd_pcm_lib_interleave_len()
just returns the (sample_width * voice_count / 8). 

shouldn't snd_pcm_lib_interleave_len return 0 if

	  subchn->hw->chninfo & SND_PCM_CHNINFO_NONINTERLEAVE

is true and perhaps even if

	  subchn->hw->chninfo & SND_PCM_CHNINFO_INTERLEAVE

is false ?


------
To unsubscribe from <alsa-devel@alsa-project.org> mailing list send message
'unsubscribe' in the body of message to <alsa-devel-request@alsa-project.org>.
BUG/SMALL PATCH REPORTING SYSTEM: http://www.alsa-project.org/cgi-bin/bugs

[prev in list] [next in list] [prev in thread] [next in thread]