[prev in list] [next in list] [prev in thread] [next in thread] 

List:       alsa-devel
Subject:    Re: [PATCH 1/2] ALSA: hda/realtek: Add quirk for ASUS ROG GX650P
From:       Luke Jones <luke () ljones ! dev>
Date:       2023-06-30 23:54:22
Message-ID: edee8624d54d92fdf8de1ae98bb6f2c2c5c08506.camel () ljones ! dev
[Download RAW message or body]

On Fri, 2023-06-30 at 10:29 +0200, Takashi Iwai wrote:
> On Fri, 30 Jun 2023 06:31:05 +0200,
> Luke D. Jones wrote:
> > 
> > --- a/sound/pci/hda/patch_realtek.c
> > +++ b/sound/pci/hda/patch_realtek.c
> > @@ -5883,7 +5883,7 @@ static void
> > alc_fixup_headset_mode_alc255_no_hp_mic(struct hda_codec *codec,
> >                 struct alc_spec *spec = codec->spec;
> >                 spec->parse_flags |= HDA_PINCFG_HEADSET_MIC;
> >                 alc255_set_default_jack_type(codec);
> > -       } 
> > +       }
> >         else
> >                 alc_fixup_headset_mode(codec, fix, action);
> >  }
> 
> This change looks irrelevant.  Could you drop it?
> If it needs to be fixed, put in another cleanup patch.
> 
> 
> thanks,
> 
> Takashi

Looks like it was a whitespace thing that got caught when saved in my
editor. I'll drop and send cleanup.

[prev in list] [next in list] [prev in thread] [next in thread]