[prev in list] [next in list] [prev in thread] [next in thread] 

List:       alsa-devel
Subject:    Re: [PATCH] ALSA: emu10k1: macro-ize snd_emu10k1_ptr_{read,write}()
From:       Takashi Iwai <tiwai () suse ! de>
Date:       2023-04-28 10:32:51
Message-ID: 87y1mcqoto.wl-tiwai () suse ! de
[Download RAW message or body]

On Fri, 28 Apr 2023 11:59:41 +0200,
Oswald Buddenhagen wrote:
> 
> The idea to encode the bitfield manipulation in the register address is
> quite clever, but it's somewhat wasteful to do these calculations at
> runtime, given that they are all constants. Change that.
> 
> The added bitfield manipulation macros will be used separately as well.
> 
> Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>

JFYI, I postpone applying this and the rest emu10k1 changes, since
it's in a merge window now.  They will be reviewed and merged for 6.5
after the 6.4 merge window.

The patch "[PATCH RESEND] ALSA: emu10k1: use more existing defines
instead of open-coded numbers" was already taken as it was a resent
patch.

So, if you have patches that fix bugs and should be applied soonish,
submit those.


thanks,

Takashi
[prev in list] [next in list] [prev in thread] [next in thread]