[prev in list] [next in list] [prev in thread] [next in thread] 

List:       alsa-devel
Subject:    Re: [PATCH -next] slimbus: qcom-ngd: Fix build error when CONFIG_SLIM_QCOM_NGD_CTRL=y && CONFIG_QCOM
From:       Srinivas Kandagatla <srinivas.kandagatla () linaro ! org>
Date:       2022-10-31 18:28:35
Message-ID: addac524-a168-16ba-c736-5b116b6e98af () linaro ! org
[Download RAW message or body]



On 27/10/2022 10:59, Zheng Bin wrote:
> If CONFIG_SLIM_QCOM_NGD_CTRL=y, CONFIG_QCOM_RPROC_COMMON=m, COMPILE_TEST=y,
> bulding fails:
> 
> drivers/slimbus/qcom-ngd-ctrl.o: In function `qcom_slim_ngd_ctrl_probe':
> qcom-ngd-ctrl.c:(.text+0x330): undefined reference to `qcom_register_ssr_notifier'
> qcom-ngd-ctrl.c:(.text+0x5fc): undefined reference to \
>                 `qcom_unregister_ssr_notifier'
> drivers/slimbus/qcom-ngd-ctrl.o: In function `qcom_slim_ngd_remove':
> qcom-ngd-ctrl.c:(.text+0x90c): undefined reference to \
> `qcom_unregister_ssr_notifier' 
> Make SLIM_QCOM_NGD_CTRL depends on QCOM_RPROC_COMMON || (COMPILE_TEST && \
> !QCOM_RPROC_COMMON) to fix this. 
> Fixes: e291691c6977 ("slimbus: qcom-ngd-ctrl: allow compile testing without \
>                 QCOM_RPROC_COMMON")
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> ---

Applied thanks,

--srini
> drivers/slimbus/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig
> index 2ed821f75816..a0fdf9d792cb 100644
> --- a/drivers/slimbus/Kconfig
> +++ b/drivers/slimbus/Kconfig
> @@ -23,7 +23,7 @@ config SLIM_QCOM_CTRL
> config SLIM_QCOM_NGD_CTRL
> 	tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component"
> 	depends on HAS_IOMEM && DMA_ENGINE && NET
> -	depends on QCOM_RPROC_COMMON || COMPILE_TEST
> +	depends on QCOM_RPROC_COMMON || (COMPILE_TEST && !QCOM_RPROC_COMMON)
> 	depends on ARCH_QCOM || COMPILE_TEST
> 	select QCOM_QMI_HELPERS
> 	select QCOM_PDR_HELPERS
> --
> 2.31.1
> 


[prev in list] [next in list] [prev in thread] [next in thread]