[prev in list] [next in list] [prev in thread] [next in thread] 

List:       alsa-devel
Subject:    [alsa-devel] [PATCH 3/3] ASoC: mxs: add some error messages to help identifying problems
From:       festevam () gmail ! com (Fabio Estevam)
Date:       2013-07-31 22:11:48
Message-ID: CAOMZO5BeFq+PxDtJ12H=d8Y=qu8Gyd4wAn=7+mzbx+_OyaUg2g () mail ! gmail ! com
[Download RAW message or body]

On Wed, Jul 31, 2013 at 11:44 AM, Lothar Wa?mann <LW at karo-electronics.de> wrote:

>         /* Set SGTL5000's SYSCLK (provided by SAIF MCLK) */
>         ret = snd_soc_dai_set_sysclk(codec_dai, SGTL5000_SYSCLK, mclk, 0);
> -       if (ret)
> +       if (ret) {
> +               dev_err(codec_dai->dev, "Failed to set sysclk to %u kHz\n",
> +                       mclk / 1000);

Wouldn't it make more sense to express it in MHz instead of kHz?

>                 return ret;
> +       }
>
>         /* The SAIF MCLK should be the same as SGTL5000_SYSCLK */
>         ret = snd_soc_dai_set_sysclk(cpu_dai, MXS_SAIF_MCLK, mclk, 0);
> -       if (ret)
> +       if (ret) {
> +               dev_err(cpu_dai->dev, "Failed to set sysclk to %u kHz\n",
> +                       mclk / 1000);

Same here.

[prev in list] [next in list] [prev in thread] [next in thread]