[prev in list] [next in list] [prev in thread] [next in thread] 

List:       alsa-devel
Subject:    [alsa-devel] [PATCH 12/17] ASoC: tegra: utils: add support for Tegra30 devices
From:       broonie () opensource ! wolfsonmicro ! com (Mark Brown)
Date:       2012-03-31 20:20:15
Message-ID: 20120331202015.GN5012 () opensource ! wolfsonmicro ! com
[Download RAW message or body]

On Fri, Mar 30, 2012 at 05:07:27PM -0600, Stephen Warren wrote:

> -	ret = tegra_asoc_utils_init(&alc5632->util_data, &pdev->dev);
> +	ret = tegra_asoc_utils_init(&alc5632->util_data,
> +				    TEGRA_ASOC_UTILS_SOC_TEGRA20, &pdev->dev);

Would it not be more sensible to do cpu_is_() calls in the utils code
rather than have the board say?  It'd possibly also end up looking nicer
in the code and may mean the compiler can figure out not to include
cases that can't be taken in the current build.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20120331/023a06e3/attachment.sig 

[prev in list] [next in list] [prev in thread] [next in thread]