[prev in list] [next in list] [prev in thread] [next in thread] 

List:       alsa-devel
Subject:    [alsa-devel] i think ac97 needs an is_surback_on() function
From:       john.utz () dmx ! com (John L !  Utz III)
Date:       2008-08-27 22:02:05
Message-ID: op.ugkfhrwh647oa9 () jutz-gnto64
[Download RAW message or body]

On Sun, 24 Aug 2008 23:27:48 -0700, Takashi Iwai <tiwai at suse.de> wrote:

> At Fri, 22 Aug 2008 15:20:09 -0700,
> John L. Utz III wrote:
>>
>> ac97_patch.c provides two helper functions that wrap the channel_mode
>> variable, but they only take you out to 5.1 Audio:
>>
>> static inline int is_surround_on(struct snd_ac97 *ac97)
>> {
>> 	return ac97->channel_mode >= 1;
>> }
>>
>> static inline int is_clfe_on(struct snd_ac97 *ac97)
>> {
>> 	return ac97->channel_mode >= 2;
>> }
>>
>>
>> For 7.1 Audio, i think there needs to be a test for 'Surround Back' or
>> 'Back Surround'
>>
>> static inline int is_surback_on(struct snd_ac97 *ac97)
>> {
>> 	return ac97->channel_mode >= 4;
>> }
>>
>>
>> Am i correct? or am i mistaken? agreement or corrections appreciated!
>
> It's correct.  The code for 7.1-audio capability was added recently.

Good. I'm not crazy then. Ok, maybe i am, but not about this. :-)

I'll submit this in follow on work to support creating an improved  
via8237.conf

tnx!

johnu

>
> Takashi
>




[prev in list] [next in list] [prev in thread] [next in thread]