[prev in list] [next in list] [prev in thread] [next in thread] 

List:       activemq-dev
Subject:    Re: [DISCUSS] moving the artemis examples to their own git repository
From:       Robbie Gemmell <robbie.gemmell () gmail ! com>
Date:       2023-12-14 18:05:00
Message-ID: CAFitrpRvM9B8k4Kd6Y3NqtRg05qmdnyP4O+w9n5z3LTutSd7mA () mail ! gmail ! com
[Download RAW message or body]

I created the new examples repo earlier today:
https://github.com/apache/activemq-artemis-examples

I also raised a PR for the main artemis repo to remove the examples
there and update things to reflect using the new repo:
https://github.com/apache/activemq-artemis/pull/4711

On Tue, 12 Dec 2023 at 17:59, Robbie Gemmell <robbie.gemmell@gmail.com> wrote:
>
> I've been doing some playing on this over time since raising the idea
> for discussion, trying out some stuff out on my github repos/fork and
> seeing how things could work. I think things are now in a state where
> further work could instead continue in such a new
> activemq-artemis-examples repo. I'll look to create that soon.
>
> https://github.com/gemmellr/activemq-artemis-examples has some initial
> work on a standalone examples build, with CI job for handling release
> + dev artemis versions on respective branches, and inputs to trigger
> manual CI runs on the development branch with any specified artemis
> repo+branch (e.g for testing your changes from your respective
> examples + artemis repo forks). The main branch is set up for the
> current 2.31.2 release, with the development branch set up for
> 2.32.0-SNAPSHOT and already incorporating the couple of actual
> examples changes made in the artemis repo since 2.31.2 was released.
>
> https://github.com/gemmellr/activemq-artemis/tree/examples-independent
> is a branch on my fork that has some changes on removing the examples
> from the main artemis repo, and updating the existing CI job checks to
> use the new examples repo instead (well, my examples repo playground
> above, currently), or again any specified examples repo+branch on a
> manual triggered run for pre-testing with changes in your respective
> forks.
>
> Robbie
>
> On Thu, 26 Oct 2023 at 15:42, Robbie Gemmell <robbie.gemmell@gmail.com> wrote:
> >
> > The default branch would align to the current release. We could have a
> > separate branch aimed towards the next release for adding new ones as
> > we go, it would be used for CI checks. We could tag older versions if
> > we desired...looking at others, some dont, some do.
> >
> > On Thu, 26 Oct 2023 at 15:25, Justin Bertram <jbertram@apache.org> wrote:
> > >
> > > +1
> > >
> > > We'll need to think about how we want to communicate the compatibility of
> > > each example since new examples may be added corresponding to new features
> > > in the broker.
> > >
> > >
> > > Justin
> > >
> > > On Thu, Oct 26, 2023 at 5:21 AM Robbie Gemmell <robbie.gemmell@gmail.com>
> > > wrote:
> > >
> > > > I'd like to move the artemis examples out of the main build+repo and
> > > > into a specific repo of their own.
> > > >
> > > > There are a significant number of them, most of which rarely change,
> > > > and I think it would be nicer to have them sitting standalone. Having
> > > > them in-build somewhat complicates things as they are, and also quite
> > > > significantly slows down the release process currently. The repo/build
> > > > also tends to be marked for security issues that are only related to
> > > > the examples components (obviously we'd still want to update things in
> > > > the separate repo, but theyd at least be separate). The nightly
> > > > snapshot deploy job takes an age, mostly due to the examples. There is
> > > > really no reason we should be deploying them, so I'd also stop doing
> > > > that in a shift; I wouldnt actually envisage us releasing the examples
> > > > at all. We would set up the CI to continue building them similarly to
> > > > as we do now, theyd just sit separately.
> > > >
> > > > Several other projects also use separate repos for their examples,
> > > > especially those with many of them. Specific cases I can think of
> > > > coming across most regularly are probably the multiple variants of
> > > > Camel, and Quarkus. On searching here at the ASF there do appear to be
> > > > various other projects that do this too:
> > > >
> > > > https://github.com/orgs/apache/repositories?language=&q=examples&sort=&type=all
> > > >
> > > > Thoughts?
> > > >
> > > > Robbie
> > > >
> > > >
[prev in list] [next in list] [prev in thread] [next in thread]