[prev in list] [next in list] [prev in thread] [next in thread] 

List:       activemq-dev
Subject:    Re: [VOTE] Apache ActiveMQ 5.17.0 release
From:       Jean-Baptiste_Onofré <jb () nanthrax ! net>
Date:       2022-03-09 19:32:15
Message-ID: CAB8EV3T44=-z5FhsoQQkn-xU93fUtYsSErEcciJO-XpOw+usBQ () mail ! gmail ! com
[Download RAW message or body]


-1

due to the issue we found with Chris. I'm preparing a PR.
I gonna send another email to cancel this vote and prepare a new one.

Regards
JB

On Wed, Mar 9, 2022 at 8:17 PM Christopher Shannon <
christopher.l.shannon@gmail.com> wrote:

> JB narrowed the issue down to <Export-Package>*</Export-Package> as part of
> the bundle plugin inside of activemq-client, activemq-jms-pool,
> activemq-pool poms and is working on a PR now to fix it
>
> On Wed, Mar 9, 2022 at 12:56 PM Robbie Gemmell <robbie.gemmell@gmail.com>
> wrote:
>
> > I would have voted positively had Chris not already found the issues
> > he did, which indeed seem like they need fixed.
> >
> > I checked things out as follows:
> > - Verified the signature + checksum files.
> > - Checked for LICENCE and NOTICE files present in the archives.
> > - Checked headers in the source archive with: mvn apache-rat:check
> > - Ran the source build, plus the AMQP integration tests, on JDK 11.
> > - Ran the Qpid JMS 1.5.0 HelloWorld against a broker started from the
> > tar.gz binary archive on JDK 11 and JDK 17.
> >
> > Robbie
> >
> > On Wed, 9 Mar 2022 at 15:46, Christopher Shannon
> > <christopher.l.shannon@gmail.com> wrote:
> > >
> > > Unfortunately I have to change my vote to -1.
> > >
> > > It looks like the activemq-pool jar is now shaded and pulling in a
> bunch
> > of
> > > other stuff. This caused my build to break as it pulled in the old
> > > javax.annotation packages which broke due to:
> > > https://issues.apache.org/jira/browse/AMQ-8530
> > >
> > > So I think we need to cancel the vote and fix the build so it's not
> > shaded
> > > (I assume it's an OSGi issue). We can also go ahead and merge in
> AMQ-8530
> > > (and some other test fixes)
> > >
> > > On Tue, Mar 8, 2022 at 3:18 PM francois.papon <
> > francois.papon@openobject.fr>
> > > wrote:
> > >
> > > > +1 (non-binding)Tested with some internal projects.Thanks
> > > > JB!regardsFrançois
> > > > -------- Message d'origine --------De : Jean-Baptiste Onofré <
> > > > jb@nanthrax.net> Date : 07/03/2022  18:25  (GMT+01:00) À :
> > > > dev@activemq.apache.org Objet : [VOTE] Apache ActiveMQ 5.17.0
> release
> > Hi
> > > > guys,*Finally*, after several weeks waiting, I'm pleased to submit
> > > > ApacheActiveMQ 5.17.0 release to your vote.This release is an
> important
> > > > milestone in ActiveMQ roadmap, including 200issues, especially:-
> > support
> > > > Spring 5.x- support log4j 2.x (2.17.1)- JDK 11+ support for both
> build
> > and
> > > > runtime- remove of activemq-camel component (replaced by
> camel-activemq
> > > > andcamel-jms components)- remove leveldb- tons of fixes and
> dependency
> > > > updatesPlease take a look on the Release Notes for details:
> > > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12346476Maven
> > > > Staging Repository:
> > > >
> >
> https://repository.apache.org/content/repositories/orgapacheactivemq-1247/Dist
> > > > Staging Repository:
> > > > https://dist.apache.org/repos/dist/dev/activemq/activemq/5.17.0/Git
> > tag:
> > > > activemq-5.17.0Please vote to approve this release:[ ] +1 Approve the
> > > > release[ ] -1 Don't approve the release (please provide specific
> > > > comments)This vote will be open for at least 72 hours.Thanks
> !RegardsJB
> >
>


[prev in list] [next in list] [prev in thread] [next in thread]