[prev in list] [next in list] [prev in thread] [next in thread] 

List:       activemq-dev
Subject:    Re: [VOTE] Apache ActiveMQ 5.16.4 release
From:       Jean-Baptiste Onofre <jb () nanthrax ! net>
Date:       2022-02-05 14:55:18
Message-ID: E9ACF1C1-EFBE-4864-A9AC-2F97D8737F2F () nanthrax ! net
[Download RAW message or body]

Hi guys,

Just a note: there's a test for AMQ-8372 (I checked on the original PR before \
merging), see:

https://github.com/apache/activemq/blob/main/activemq-unit-tests/src/test/java/org/apache/activemq/broker/jmx/MBeanTest.java#L121
 https://github.com/apache/activemq/blob/main/activemq-unit-tests/src/test/java/org/apache/activemq/broker/jmx/MBeanTest.java#L733


So we are good with this one.

Lucas added a test for AMQ-8053: https://github.com/apache/activemq/pull/755 (I'm \
reviewing it right now).

I know Matt is working on tests for AMQ-8397 and AMQ-8443.

Regards
JB

> Le 2 févr. 2022 à 19:56, Christopher Shannon <christopher.l.shannon@gmail.com> a \
> écrit : 
> Unfortunately I am -1. I just checked the release and several Jiras don't
> have any unit tests for verification.
> 
> https://issues.apache.org/jira/browse/AMQ-8053
> https://issues.apache.org/jira/browse/AMQ-8372
> https://issues.apache.org/jira/browse/AMQ-8397
> https://issues.apache.org/jira/browse/AMQ-8443
> 
> There might be more, I quit checking after the first several. All of these
> fixes and improvements need tests. It's important to add some tests to
> verify the actual bug or issue and to make sure it doesn't get broken in
> the future. I am not comfortable releasing this without having tests for
> these issues. The same of course goes into anything with 5.17.0. Obviously
> we don't need tests for trivial stuff (dependency upgrades, null pointer
> checks, etc) but other stuff should be tested.
> 
> The biggest issue I have is AMQ-8443 which claims this is a fix for the
> "failover transport reconnect not working" but no demonstration of the
> issue or how the fix works in a unit test.
> 
> On Wed, Feb 2, 2022 at 3:29 AM Francois Papon <francois.papon@openobject.fr>
> wrote:
> 
> > +1 (non-binding)
> > 
> > Thanks!
> > 
> > regards,
> > 
> > François
> > 
> > On 01/02/2022 21:41, Jean-Baptiste Onofre wrote:
> > > Hi everyone,
> > > 
> > > I submit Apache ActiveMQ 5.16.4 release to your vote.
> > > 
> > > This release includes important fixes and updates on the 5.16.x series,
> > especially:
> > > - fix couple of warnings/issues on JDK16+
> > > - fix stack trace display on transports
> > > - better secure on WebConsole
> > > - several dependencies updates
> > > - and much more!
> > > 
> > > Please take a look on the Release Notes for details:
> > > 
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12350483
> > 
> > > 
> > > Maven staging repository is:
> > > 
> > https://repository.apache.org/content/repositories/orgapacheactivemq-1244/
> > > 
> > > Dist staging repository is:
> > > https://dist.apache.org/repos/dist/dev/activemq/activemq/5.16.4/
> > > 
> > > Git tag:
> > > activemq-5.16.4
> > > 
> > > Please vote to approve this release:
> > > 
> > > [ ] +1 Approve the release
> > > [ ] -1 Don't approve the release (please provide specific comments)
> > > 
> > > This vote will be open for at least 72 hours.
> > > 
> > > Thanks !
> > > Regards
> > > JB
> > 


[prev in list] [next in list] [prev in thread] [next in thread]