[prev in list] [next in list] [prev in thread] [next in thread] 

List:       activemq-dev
Subject:    [GitHub] activemq-artemis pull request #2441: Assorted Error Prone-related NO-JIRA fi...
From:       jdanekrh <git () git ! apache ! org>
Date:       2018-11-29 15:00:59
Message-ID: 20181129150059.3310FDFDA7 () git1-us-west ! apache ! org
[Download RAW message or body]

Github user jdanekrh commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2441#discussion_r237521038
  
    --- Diff: artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessageTest.java \
---  @@ -2231,14 +2232,14 @@ private boolean isEquals(Section left, Section right) {
              byte[] leftArray = leftValue.getValue().getArray();
              byte[] rightArray = rightValue.getValue().getArray();
     
    -         if (leftArray == null && leftArray == null) {
    +         if (leftArray == null && rightArray == null) {
    --- End diff --
    
    @tabish121 I figure this is what you've meant to say here (error prone screams if \
there are duplicated subexpressions in ifs, like this)


---


[prev in list] [next in list] [prev in thread] [next in thread]