[prev in list] [next in list] [prev in thread] [next in thread] 

List:       activemq-dev
Subject:    [GitHub] activemq-artemis issue #1677: Allow mqtt with dynamic cluster
From:       jbertram <git () git ! apache ! org>
Date:       2017-11-28 18:07:31
Message-ID: 20171128180731.736D0DFB78 () git1-us-west ! apache ! org
[Download RAW message or body]

Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1677
  
    > Can you help me understand how the commits should be organized?
    Commits should be organized into logical units.  You shouldn't have a commit \
adding the example and then a handful of smaller commits fixing stuff in the example \
you added in a previous commit.  All those commits should be squashed together into a \
single commit and then the commit message should follow the recommendation from the \
[Hacking Guide](https://github.com/apache/activemq-artemis/blob/master/docs/hacking-guide/en/maintainers.md#commit-messages). \
Git makes it easy to manipulate commits so take advantage of its power.  
    Once everything is organized in a sane manner I'll take a look at the actual \
commit (assuming I have time).


---


[prev in list] [next in list] [prev in thread] [next in thread]