[prev in list] [next in list] [prev in thread] [next in thread] 

List:       activemq-dev
Subject:    [jira] [Assigned] (AMQ-4997) Dead code in VMTransport class
From:       "Kevin Earls (JIRA)" <jira () apache ! org>
Date:       2014-01-30 16:02:09
Message-ID: JIRA.12692002.1390992140535.10889.1391097729338 () arcas
[Download RAW message or body]


     [ https://issues.apache.org/jira/browse/AMQ-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel \
]

Kevin Earls reassigned AMQ-4997:
--------------------------------

    Assignee: Kevin Earls

> Dead code in VMTransport class
> ------------------------------
> 
> Key: AMQ-4997
> URL: https://issues.apache.org/jira/browse/AMQ-4997
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.9.0
> Reporter: Yuriy Sidelnikov
> Assignee: Kevin Earls
> Priority: Minor
> 
> The object with name DISCONNECT is created as 
> private static final Object DISCONNECT = new Object();
> so it can't be modified of be overwritten somewhere outside this class.
> However this reference is used only two times to check if:
> public void doDispatch(VMTransport transport, TransportListener transportListener, \
> Object command) { if (command == DISCONNECT) {
> transportListener.onException(new TransportDisposedIOException("Peer (" + \
> peer.toString() + ") disposed.")); } else {
> transport.receiveCounter++;
> transportListener.onCommand(command);
> }
> }
> and 
> if( command == DISCONNECT ) {
> tl.onException(new TransportDisposedIOException("Peer (" + peer.toString() + ") \
> disposed.")); } else {
> tl.onCommand(command);
> }
> so only one branch of ifs will be run.
> Seems as some remnant of modification? 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[prev in list] [next in list] [prev in thread] [next in thread]