[prev in list] [next in list] [prev in thread] [next in thread] 

List:       activemq-dev
Subject:    [jira] Resolved: (AMQ-2045) Unbalanced Valve usage in VMTransport.
From:       "David Jencks (JIRA)" <jira () apache ! org>
Date:       2008-12-29 7:59:06
Message-ID: 135277501.1230537546381.JavaMail.jira () brutus
[Download RAW message or body]


     [ https://issues.apache.org/activemq/browse/AMQ-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel \
]

David Jencks resolved AMQ-2045.
-------------------------------

    Resolution: Fixed
      Assignee: Hiram Chirino  (was: David Jencks)

rev 729835 adds consistency checks to Valve and removes the unbalanced decrement.  \
IMO this should be reviewed by a more knowledgeable developer before closing... Hiram \
can you take a look or suggest someone who could?

> Unbalanced Valve usage in VMTransport.
> --------------------------------------
> 
> Key: AMQ-2045
> URL: https://issues.apache.org/activemq/browse/AMQ-2045
> Project: ActiveMQ
> Issue Type: Bug
> Components: Transport
> Affects Versions: 5.3.0
> Reporter: David Jencks
> Assignee: Hiram Chirino
> Fix For: 5.3.0
> 
> 
> Valve doesn't check that its state is consistent (counters >= 0).  There's \
> unbalanced increment/decrement calls in VMTransport.oneway: \
> enqueueValve.decrement();  //TODO unbalanced?? (line ~99) 
> If I balance this with a preceding enqueValve.increment() I get a deadlock in a \
> test when the server tries to send a response message so I assume the correct fix \
> is to remove the decrement in this VMTransports valve.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[prev in list] [next in list] [prev in thread] [next in thread]