[prev in list] [next in list] [prev in thread] [next in thread] 

List:       acpi4linux
Subject:    [ACPI] [PATCH] thermal active cooling step
From:       "Wang, Zhenyu Z" <zhenyu.z.wang () intel ! com>
Date:       2004-05-28 5:23:46
Message-ID: 6E0C289723A0564F9A8279E236E8565F078052FF () pdsmsx402 ! pd ! intel ! com
[Download RAW message or body]

Hi,

I have a question about thermal active cooling process that we do 
in acpi_thermal_active. 
For example, if _AC0 is lower than current temperature, we set maxtemp
to _AC0's temperature then turn it on. Next step is checking _AC1, if
_AC1 
is also lower than current, we turn it on by ignore maxtemp in current
code.

According to the Spec, _AC0 should be greater than _AC1's cooling
strength.
(If two fans are in system, AC0 includes both two and AC1 may include
one of them)
So i think the variable maxtemp seems not be used properly here.

Pls, see my patch attached. And correct me if I am wrong.

thanks,
-zhen

["tz_active.patch" (application/octet-stream)]

--- linux-2.6.6-acpi/drivers/acpi/thermal.c.orig	2004-05-28 11:18:46.426467912 +0800
+++ linux-2.6.6-acpi/drivers/acpi/thermal.c	2004-05-28 11:41:55.477300088 +0800
@@ -603,7 +603,7 @@ acpi_thermal_active (
 		 * associated with this active threshold.
 		 */
 		if (tz->temperature >= active->temperature) {
-			if (active->temperature > maxtemp)
+			if (active->temperature > maxtemp){
 				tz->state.active_index = i, maxtemp = active->temperature;
 			if (!active->flags.enabled) {
 				for (j = 0; j < active->devices.count; j++) {
@@ -616,6 +616,7 @@ acpi_thermal_active (
 					ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Cooling device [%p] now 'on'\n", active->devices.handles[j]));
 				}
 			}
+			}
 		}
 		/*
 		 * Below Threshold?

-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. 
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click
_______________________________________________
Acpi-devel mailing list
Acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acpi-devel

[prev in list] [next in list] [prev in thread] [next in thread]