[prev in list] [next in list] [prev in thread] [next in thread] 

List:       9fans
Subject:    Re: [9fans] Blocking on write
From:       Giacomo Tesio <giacomo () tesio ! it>
Date:       2017-05-17 15:46:31
Message-ID: CAHL7psFhY7tme+kNjcLnEGPYxtvYO2NDwbtttVBRiCYx0UkPQA () mail ! gmail ! com
[Download RAW message or body]

In Jehanne, I decided to test both: if the queue is not closed there's no
need to check up->errstr.

Thanks for your help!


Giacomo

2017-05-15 18:12 GMT+02:00 Charles Forsyth <charles.forsyth@gmail.com>:

>
> On 15 May 2017 at 16:46, Giacomo Tesio <giacomo@tesio.it> wrote:
>
>> Shouldn't the waserror code check that the queue has been actually closed?
>
>
> Either that or check errstr against Ehungup, since that's the exact error
> it incurred.
> The latter has the advantage of not obscuring a different error if the
> pipe is closed
> between the write and waserror, but with pipes there's not much except
> interrupt, I suppose,
> so it seems a minor race and perhaps the qclosed check is adequate.
>

[Attachment #3 (text/html)]

<div dir="ltr"><div><div>In Jehanne, I decided to test both: if the queue is not \
closed there&#39;s no need to check up-&gt;errstr.<br><br></div>Thanks for your \
help!<br><br><br></div>Giacomo<br></div><div class="gmail_extra"><br><div \
class="gmail_quote">2017-05-15 18:12 GMT+02:00 Charles Forsyth <span dir="ltr">&lt;<a \
href="mailto:charles.forsyth@gmail.com" \
target="_blank">charles.forsyth@gmail.com</a>&gt;</span>:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><span \
class=""><br><div class="gmail_quote">On 15 May 2017 at 16:46, Giacomo Tesio <span \
dir="ltr">&lt;<a href="mailto:giacomo@tesio.it" \
target="_blank">giacomo@tesio.it</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Shouldn&#39;t the waserror code check that the queue has been \
actually closed?</blockquote></div><br></span>Either that or check errstr against \
Ehungup, since that&#39;s the exact error it incurred.</div><div \
class="gmail_extra">The latter has the advantage of not obscuring a different error \
if the pipe is closed</div><div class="gmail_extra">between the write and waserror, \
but with pipes there&#39;s not much except interrupt, I suppose,</div><div \
class="gmail_extra">so it seems a minor race and perhaps the qclosed check is \
adequate.</div></div> </blockquote></div><br></div>



[prev in list] [next in list] [prev in thread] [next in thread]