[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: [kmime] src: Minor optimization. Remove unused variable. Don't duplicate method + variables
From: Montel Laurent <null () kde ! org>
Date: 2017-05-31 20:48:56
Message-ID: E1dGAY4-0003mp-Rf () code ! kde ! org
[Download RAW message or body]
Git commit 3a49997960dcd306e8d233600759c494126dbca5 by Montel Laurent.
Committed on 31/05/2017 at 20:48.
Pushed by mlaurent into branch 'master'.
Minor optimization. Remove unused variable. Don't duplicate method + variables
M +4 -4 src/kmime_parsers.cpp
M +0 -5 src/kmime_parsers.h
https://commits.kde.org/kmime/3a49997960dcd306e8d233600759c494126dbca5
diff --git a/src/kmime_parsers.cpp b/src/kmime_parsers.cpp
index ff5a24c..843ea56 100644
--- a/src/kmime_parsers.cpp
+++ b/src/kmime_parsers.cpp
@@ -120,6 +120,7 @@ NonMimeParser::~NonMimeParser() {}
/**
* try to guess the mimetype from the file-extension
*/
+
QByteArray NonMimeParser::guessMimeType(const QByteArray &fileName)
{
QByteArray tmp, mimeType;
@@ -274,7 +275,7 @@ bool UUEncoded::parse()
// append trailing text part of the article
m_text.append(m_src.right(m_src.length() - currentPos));
- return ((m_bins.count() > 0) || isPartial());
+ return ((!m_bins.isEmpty()) || isPartial());
}
//==============================================================================
@@ -320,11 +321,10 @@ bool YENCEncoded::parse()
{
int currentPos = 0;
bool success = true;
-
while (success) {
int beginPos = currentPos, yencStart = currentPos;
bool containsPart = false;
- QByteArray fileName, mimeType;
+ QByteArray fileName;
if ((beginPos = m_src.indexOf("=ybegin ", currentPos)) > -1 &&
(beginPos == 0 || m_src.at(beginPos - 1) == '\n')) {
@@ -499,7 +499,7 @@ bool YENCEncoded::parse()
// append trailing text part of the article
m_text.append(m_src.right(m_src.length() - currentPos));
- return m_bins.count() > 0;
+ return !m_bins.isEmpty();
}
} // namespace Parser
diff --git a/src/kmime_parsers.h b/src/kmime_parsers.h
index 8b0b2e0..e538e85 100644
--- a/src/kmime_parsers.h
+++ b/src/kmime_parsers.h
@@ -136,13 +136,8 @@ public:
explicit YENCEncoded(const QByteArray &src);
bool parse() Q_DECL_OVERRIDE;
- QVector<QByteArray> binaryParts() const
- {
- return m_bins;
- }
private:
- QVector<QByteArray> m_bins;
static bool yencMeta(QByteArray &src, const QByteArray &name, int *value);
};
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic