[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: Re: extragear/multimedia/amarok
From: "Seb Ruiz" <ruiz () kde ! org>
Date: 2009-01-10 2:31:18
Message-ID: 60ebdd0b0901091831m4671f101ia0bd6cb41fa2044b () mail ! gmail ! com
[Download RAW message or body]
2009/1/10 Dan Meltzer <parallelgrapefruit@gmail.com>:
> This doesn't check to see if track->album() is valid.
Good catch
>
> On 1/9/09, Seb Ruiz <ruiz@kde.org> wrote:
>> SVN commit 908640 by seb:
>>
>> Cover art can get/set from the script API.
>> BUG: 179732
>>
>> M +2 -0 ChangeLog
>> M +13 -0 src/scriptengine/MetaTypeExporter.cpp
>> M +4 -2 src/scriptengine/MetaTypeExporter.h
>>
>>
>> --- trunk/extragear/multimedia/amarok/ChangeLog #908639:908640
>> @@ -5,6 +5,8 @@
>>
>> VERSION 2.1
>> FEATURES:
>> + * Album cover art can be accessed via the scripting API. Patch thanks
>> to
>> + Simon Esneault <simon.esneault@gmail.com>. (BR 179732)
>> * New vertical Context View layout.
>> * New applet toolbar in the Context View to arrange, select, and add
>> applets.
>>
>> --- trunk/extragear/multimedia/amarok/src/scriptengine/MetaTypeExporter.cpp
>> #908639:908640
>> @@ -173,6 +173,12 @@
>> return track ? track->prettyName() : QString();
>> }
>>
>> +QString
>> +MetaTrackPrototype::imageUrl() const
>> +{
>> + GET_TRACK
>> + return track ? track->album()->imageLocation().prettyUrl() : QString();
>> +}
>>
>> bool
>> MetaTrackPrototype::isValid() const
>> @@ -279,6 +285,13 @@
>> if ( ec ) ec->setTitle( title );
>> }
>>
>> +void
>> +MetaTrackPrototype::setImageUrl(const QString& imageUrl )
>> +{
>> + GET_TRACK
>> + if ( track ) track->album()->setImage(QImage(imageUrl));
>> +}
>> +
>> #undef GET_TRACK
>> #undef GET_TRACK_EC
>>
>> --- trunk/extragear/multimedia/amarok/src/scriptengine/MetaTypeExporter.h
>> #908639:908640
>> @@ -51,6 +51,7 @@
>> Q_PROPERTY( bool isValid READ isValid )
>> Q_PROPERTY( bool isEditable READ isEditable )
>> Q_PROPERTY( QString lyrics WRITE setLyrics READ lyrics )
>> + Q_PROPERTY( QString imageUrl WRITE setImageUrl READ imageUrl )
>>
>> public:
>> MetaTrackPrototype();
>> @@ -80,7 +81,8 @@
>> bool isEditable() const;
>> QString lyrics() const;
>> QString title() const;
>> - //coverImage
>> + QString imageUrl() const;
>> +
>> void setScore( double score );
>> void setRating( int rating );
>> void setTrackNumber( int number );
>> @@ -93,7 +95,7 @@
>> void setComment( QString comment );
>> void setLyrics( QString lyrics );
>> void setTitle( const QString& name );
>> -
>> + void setImageUrl(const QString& imageUrl);
>> };
>>
>> #endif
>>
>
--
Seb Ruiz
http://www.sebruiz.net/
http://amarok.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic