[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124571: add features from kcm_useraccounts
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-07-31 22:56:59
Message-ID: 20150731225659.31864.98587 () mimi ! kde ! org
[Download RAW message or body]
--===============3405960749702698065==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124571/#review83270
-----------------------------------------------------------
src/accountinfo.cpp (line 183)
<https://git.reviewboard.kde.org/r/124571/#comment57496>
This is deprecated API
http://doc.qt.io/qt-5/qdesktopservices-obsolete.html
See QStandardPaths
src/lib/accountmodel.cpp (line 58)
<https://git.reviewboard.kde.org/r/124571/#comment57497>
leaks
also, it's better in where we construct m_sessions on line 39.
Otherwise we have a dangly pointer for half the contstructor, and when someone \
rearranges the code in the future they get a crash
- David Edmundson
On July 31, 2015, 9:17 p.m., Jonathan Riddell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124571/
> -----------------------------------------------------------
>
> (Updated July 31, 2015, 9:17 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: user-manager
>
>
> Description
> -------
>
> Save settings with m_kEmailSettings as well to replace kcm_useraccounts
> add symlink in ~/.face.icon the file used by some login managers
>
> with this we can get rid of kcm_useraccounts which just duplicates it
>
>
> Diffs
> -----
>
> src/accountinfo.cpp 78fe969
> src/lib/accountmodel.h 331c131
> src/lib/accountmodel.cpp 558aa6b
>
> Diff: https://git.reviewboard.kde.org/r/124571/diff/
>
>
> Testing
> -------
>
> edited user settings and checked ~/.config/emailsettingsrc
>
> edited user settings and checked ~/.face*
>
>
> Thanks,
>
> Jonathan Riddell
>
>
--===============3405960749702698065==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124571/">https://git.reviewboard.kde.org/r/124571/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/124571/diff/1/?file=388976#file388976line183" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/accountinfo.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
AccountInfo::save()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">183</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QString</span> <span class="n">faceFile2</span> <span class="o">=</span> \
<span class="n">QDesktopServices</span><span class="o">::</span><span \
class="n">storageLocation</span><span class="p">(</span><span \
class="n">QDesktopServices</span><span class="o">::</span><span \
class="n">HomeLocation</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
is deprecated API</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: \
inherit;">http://doc.qt.io/qt-5/qdesktopservices-obsolete.html</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See \
QStandardPaths</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/124571/diff/1/?file=388978#file388978line58" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/lib/accountmodel.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">AccountModel::AccountModel(QObject* parent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">58</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">m_kEmailSettings</span> <span class="o">=</span> <span class="k">new</span> \
<span class="n">KEMailSettings</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">leaks</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">also, it's better in where we construct \
m_sessions on line 39.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Otherwise we have a dangly pointer for \
half the contstructor, and when someone rearranges the code in the future they get a \
crash</p></pre> </div>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On July 31st, 2015, 9:17 p.m. UTC, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated July 31, 2015, 9:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
user-manager
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Save settings with m_kEmailSettings as well to replace \
kcm_useraccounts add symlink in ~/.face.icon the file used by some login managers</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">with this we can get rid of kcm_useraccounts which \
just duplicates it</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">edited user settings and checked \
~/.config/emailsettingsrc</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">edited user settings and checked \
~/.face*</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/accountinfo.cpp <span style="color: grey">(78fe969)</span></li>
<li>src/lib/accountmodel.h <span style="color: grey">(331c131)</span></li>
<li>src/lib/accountmodel.cpp <span style="color: grey">(558aa6b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124571/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3405960749702698065==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic