[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: Re: KDE/kdebase/workspace/plasma/dataengines/weather/ions
From: Shawn Starr <shawn.starr () rogers ! com>
Date: 2009-08-08 17:12:14
Message-ID: 200908081312.14768.shawn.starr () rogers ! com
[Download RAW message or body]
On Saturday 08 August 2009 03:23:34 André Wöbbeking wrote:
> On Friday 07 August 2009, Shawn Starr wrote:
> > SVN commit 1008478 by spstarr:
> >
> > Constify country(). This will always return USA, the ion doesn't
> > return other countries
> >
> > M +1 -1 ion_noaa.cpp
> > M +1 -1 ion_noaa.h
> >
> >
> > ---
> > trunk/KDE/kdebase/workspace/plasma/dataengines/weather/ions/ion_noaa
> > .h #1008477:1008478 @@ -97,7 +97,7 @@
> > QMap<QString, WindDirections> const& windIcons(void) const;
> >
> > // Place information
> > - QString country(const QString& source) const;
> > + QString const country(const QString& source) const;
>
> The returned QString doesn't need to be const and it's not in the other
> methods.
>
Only because the string never changes, it does for other places.
> > QString place(const QString& source) const;
> > QString station(const QString& source) const;
> > QString latitude(const QString& source) const;
>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic