[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: Re: KDE/kdepimlibs/kabc/plugins/dir
From: David Faure <dfaure () klaralvdalens-datakonsult ! se>
Date: 2007-05-24 10:10:33
Message-ID: 200705241210.41084.dfaure () klaralvdalens-datakonsult ! se
[Download RAW message or body]
Minor comments:
On Thursday 24 May 2007, Laurent Montel wrote:
> + kdDebug()<<" ir.entryList( QDir::Files ) :"<<dir.entryList( QDir::Files ).count()<<endl;
> + QStringList lst = dir.entryList( QDir::Files );
"const QStringList lst" to avoid a detach on lst[0] (I think)
> + if( lst.isEmpty()) //path doesn't exist or list of file empty
> + return true;
> + QString testName = lst[0];
lst.first()
> if ( testName.isNull() || testName.isEmpty() ) // no file in directory
> return true;
can be remove now, your test replaces it
--
David Faure, faure@kde.org, dfaure@klaralvdalens-datakonsult.se
KDE/KOffice developer, Qt consultancy projects
Klarälvdalens Datakonsult AB, Platform-independent software solutions
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic