[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: KDE/kdeplasma-addons/applets/lancelot/app/src (silent)
From: Jonathan Michael Thomas <echidnaman () kubuntu ! org>
Date: 2009-12-16 16:15:51
Message-ID: 1260980151.507203.16308.nullmailer () svn ! kde ! org
[Download RAW message or body]
SVN commit 1062998 by jmthomas:
SVN_SILENT: Really fix const correctness krazy warnings
M +1 -1 LancelotConfig.cpp
M +2 -2 LancelotWindow.cpp
M +3 -3 launcher/LancelotAppletConfig.cpp
M +1 -1 models/ContactsKopete.cpp
M +1 -1 models/FolderModel.cpp
M +1 -1 models/RecentDocuments.cpp
M +2 -2 models/Runner.cpp
--- trunk/KDE/kdeplasma-addons/applets/lancelot/app/src/LancelotConfig.cpp \
#1062997:1062998 @@ -65,7 +65,7 @@
if (!systemButtonActionsMenu) {
systemButtonActionsMenu = new QMenu();
Models::SystemActions * model = Models::SystemActions::self();
- foreach (const QString id, model->actions()) {
+ foreach (const QString &id, model->actions()) {
systemButtonActionsMenu->addAction(
model->actionIcon(id),
model->actionTitle(id),
--- trunk/KDE/kdeplasma-addons/applets/lancelot/app/src/LancelotWindow.cpp \
#1062997:1062998 @@ -515,7 +515,7 @@
MergedAddModel(m_modelGroups["ContactsLeft"], "Messages", \
m_models["Messages"]); } else if (plugins != "disabled") {
Lancelot::ActionListModel * model;
- foreach (const QString plugin, plugins.split(',')) {
+ foreach (const QString &plugin, plugins.split(',')) {
model = new Lancelot::PlasmaServiceListModel(plugin);
MergedAddModel(m_modelGroups["ContactsLeft"], model->selfTitle(), \
model); }
@@ -528,7 +528,7 @@
MergedAddModel(m_modelGroups["ContactsRight"], "Contacts", \
m_models["Contacts"]); } else if (plugins != "disabled") {
Lancelot::ActionListModel * model;
- foreach (const QString plugin, plugins.split(',')) {
+ foreach (const QString &plugin, plugins.split(',')) {
model = new Lancelot::PlasmaServiceListModel(plugin);
MergedAddModel(m_modelGroups["ContactsRight"], model->selfTitle(), \
model); }
--- trunk/KDE/kdeplasma-addons/applets/lancelot/app/src/launcher/LancelotAppletConfig.cpp \
#1062997:1062998 @@ -125,7 +125,7 @@
QString LancelotAppletConfig::icon() const
{
- foreach (const QString id, icons.keys()) {
+ foreach (const QString &id, icons.keys()) {
QListWidgetItem * item = icons[id];
if (item->isSelected()) {
if (id == "custom") {
@@ -146,7 +146,7 @@
void LancelotAppletConfig::setShowingCategories(QStringList ids, bool value)
{
- foreach (const QString id, categories.keys()) {
+ foreach (const QString &id, categories.keys()) {
QListWidgetItem * item = categories[id];
item->setSelected((ids.contains(id)) ? value : (!value));
}
@@ -178,7 +178,7 @@
void LancelotAppletConfig::setIcon(const QString & icon)
{
bool found = false;
- foreach (const QString id, icons.keys()) {
+ foreach (const QString &id, icons.keys()) {
QListWidgetItem * item = icons[id];
item->setSelected(id == icon);
if (id == icon) {
--- trunk/KDE/kdeplasma-addons/applets/lancelot/app/src/models/ContactsKopete.cpp \
#1062997:1062998 @@ -57,7 +57,7 @@
if (m_contactsToUpdate.size() > 5) {
load(true);
} else {
- foreach(const QString contact, m_contactsToUpdate) {
+ foreach(const QString &contact, m_contactsToUpdate) {
updateContactData(contact);
}
}
--- trunk/KDE/kdeplasma-addons/applets/lancelot/app/src/models/FolderModel.cpp \
#1062997:1062998 @@ -55,7 +55,7 @@
KConfigGroup config = cfg.group("FolderModel");
QStringList items = config.readEntry(m_dirPath, QStringList());
- foreach (const QString item, items) {
+ foreach (const QString &item, items) {
if (QFile::exists(item)) {
addItem(QUrl(item).toString());
}
--- trunk/KDE/kdeplasma-addons/applets/lancelot/app/src/models/RecentDocuments.cpp \
#1062997:1062998 @@ -67,7 +67,7 @@
break;
case 1:
// clearing the list
- foreach (const QString file, QDir(m_dirPath).entryList(QDir::Files)) {
+ foreach (const QString &file, QDir(m_dirPath).entryList(QDir::Files)) {
QFile::remove(m_dirPath + '/' + file);
}
break;
--- trunk/KDE/kdeplasma-addons/applets/lancelot/app/src/models/Runner.cpp \
#1062997:1062998 @@ -184,7 +184,7 @@
}
QString id = itemAt(index).data.value< QStringList >().at(0);
- foreach (const Plasma::QueryMatch match, m_runnerManager->matches()) {
+ foreach (const Plasma::QueryMatch &match, m_runnerManager->matches()) {
if (match.id() == id) {
if (m_runnerManager->actionsForMatch(match).size() > 0) {
return true;
@@ -205,7 +205,7 @@
}
QString id = itemAt(index).data.value< QStringList >().at(0);
- foreach (const Plasma::QueryMatch match, m_runnerManager->matches()) {
+ foreach (const Plasma::QueryMatch &match, m_runnerManager->matches()) {
if (match.id() == id) {
foreach (QAction * action, m_runnerManager->actionsForMatch(match)) {
menu->addAction(action->icon(), action->text());
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic